• tal
    link
    fedilink
    English
    arrow-up
    54
    arrow-down
    1
    ·
    2 days ago

    60 req/hour for unauthenticated users

    That’s low enough that it may cause problems for a lot of infrastructure. Like, I’m pretty sure that the MELPA emacs package repository builds out of git, and a lot of that is on github.

    • Xanza@lemm.ee
      link
      fedilink
      English
      arrow-up
      31
      ·
      edit-2
      2 days ago

      That’s low enough that it may cause problems for a lot of infrastructure.

      Likely the point. If you need more, get an API key.

      • lolcatnip@reddthat.com
        link
        fedilink
        English
        arrow-up
        1
        ·
        20 hours ago

        Or just make authenticated requests. I’d expect that to be well within with capabilities of anyone using MELPA, and 5000 requests per hour shouldn’t pose any difficulty considering MELPA only has about 6000 total packages.

        • Xanza@lemm.ee
          link
          fedilink
          English
          arrow-up
          2
          ·
          16 hours ago

          This is my opinion on it, too. Everyone is crying about the death of Github when they’re just cutting back on unauthenticated requests to curb abuse… lol seems pretty standard practice to me.

    • NotSteve_@lemmy.ca
      link
      fedilink
      arrow-up
      15
      arrow-down
      3
      ·
      2 days ago

      Do you think any infrastructure is pulling that often while unauthenticated? It seems like an easy fix either way (in my admittedly non devops opinion)

      • Ephera@lemmy.ml
        link
        fedilink
        English
        arrow-up
        12
        ·
        1 day ago

        It’s gonna be problematic in particular for organisations with larger offices. If you’ve got hundreds of devs/sysadmins under the same public IP address, those 60 requests/hour are shared between them.

        Basically, I expect unauthenticated pulls to not anymore be possible at my day job, which means repos hosted on GitHub become a pain.

        • timbuck2themoon@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          2
          ·
          1 day ago

          Quite frankly, companies shouldn’t be pulling Willy nilly from github or npm, etc anyway. It’s trivial to set up something to cache repos or artifacts, etc. Plus it guards against being down when github is down, etc.

          • Ephera@lemmy.ml
            link
            fedilink
            English
            arrow-up
            2
            ·
            14 hours ago

            It’s easy to set up a cache, but what’s hard is convincing your devs to use it.

            Mainly because, well, it generally works without configuring the cache in your build pipeline, as you’ll almost always need some solution for accessing the internet anyways.

            But there’s other reasons, too. You need authentication or a VPN for accessing a cache like that. Authentications means you have to deal with credentials, which is a pain. VPN means it’s likely slower than downloading directly from the internet, at least while you’re working from home.

            Well, and it’s also just yet another moving part in your build pipeline. If that cache is ever down or broken or inaccessible from certain build infrastructure, chances are it will get removed from affected build pipelines and those devs are unlikely to come back.


            Having said that, of course, GitHub is promoting caches quite heavily here. This might make it actually worth using for the individual devs.

        • NotSteve_@lemmy.ca
          link
          fedilink
          arrow-up
          2
          ·
          1 day ago

          Ah yeah that’s right, I didn’t consider large offices. I can definitely see how that’d be a problem

      • Boomer Humor Doomergod@lemmy.world
        link
        fedilink
        English
        arrow-up
        6
        ·
        2 days ago

        If I’m using Ansible or something to pull images it might get that high.

        Of course the fix is to pull it once and copy the files over, but I could see this breaking prod for folks who didn’t write it that way in the first place